Site Editor: Animate the radius of the frame #60415
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -36 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Makes sense to me. Ideally the animation profile matches the frame, which we should continue to finesse.
Unrelated to this PR, but another small detail to fix here; when zooming in there's a brief moment where the dark background bleeds through a 1px gap directly beneath the site logo which a bit distracting:
underline.mp4
I actually don't see that on safari, only on chrome. Weird |
This was referenced Apr 3, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trunk when moving between "edit" and "view" mode in the site editor, the border radius of the frame abruptly changes from rounded to sharp. This PR animates the border radius instead.
It's a small thing but I believe the details matter.