Don't show appender at all inside sections on zoom-out mode #60948
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaggieCabrera
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
MaggieCabrera
changed the title
|
Size Change: 0 B Total Size: 1.74 MB ℹ️ View Unchanged
|
draganescu
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
This LGTM.
I wonder why in #58556 we only disabled custom appenders in zoom out. Was is a design decision?
ellatrix
reviewed
Apr 22, 2024
| ( hasCustomAppender | ||
| ? ! getTemplateLock( rootClientId ) && | ||
| getBlockEditingMode( rootClientId ) !== | ||
| 'disabled' && | ||
| __unstableGetEditorMode() !== 'zoom-out' |
There was a problem hiding this comment.
Should we consider removing this appender entirely when a block is selected? It's also often the source of layout shifts. Cc @jasmussen
There was a problem hiding this comment.
Oh yes, it's also very ugly. (sorry appender)
There was a problem hiding this comment.
should that be done on a different PR?
There was a problem hiding this comment.
definitely. maybe open a discussion to discuss and label it with needs design feedback. I don't think its a decision to take in a code comment thread.
There was a problem hiding this comment.
Yes, I'm just thinking out loud, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the black appender inside sections on zoom-out mode
Why?
We don't want to insert inside the sections at all
How?
By changing the condition that shows or hides the custom appender inside block-list
Testing Instructions
Screenshots or screencast
Before:
After: